fix(queue): time-bound queue-health history for the 30-day trend window by andriypolanski · Pull Request #10262 · JSONbored/loopover

andriypolanski · 2026-07-31T15:00:19Z

Summary

Read queue-health history through listRecentSignalSnapshotsForTargets with the same trendSince window already used for totals (QUEUE_TREND_HISTORY_DAYS), instead of unbounded listSignalSnapshots (hard 100-row cap ≈ 25 days at 4 rows/day).
Export QUEUE_TREND_SNAPSHOT_LIMIT = QUEUE_TREND_HISTORY_DAYS * 4 as the per-target backstop, and raise listRecentSignalSnapshotsForTargets' internal clamp from 100 → 500 so that backstop is not silently truncated.
Regression seeds 130 snapshots across 33 days and asserts the 30-day window gets non-null duplicateTrend and stalePullRequestRateDelta.

Scope

The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

If any required check was skipped, explain why:

Focused coverage on src/queue/signal-snapshot.ts + src/services/queue-trends.ts via test/unit/signal-snapshot-queue-trend-history.test.ts and test/unit/queue-trends.test.ts (including both arms of the ?? [] map miss). Full test:ci / UI / MCP packs deferred to CI for this queue/src-only change.

Safety

No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
API/OpenAPI/MCP behavior is updated and tested where needed.
UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A — no visible UI/frontend/docs changes.

Notes

Closes queue(signal-snapshot): time-bound the queue-health history read so the 30-day queue-trend window can resolve a baseline #10020
Mirrors the #9699 slop/duplicate trend reader pattern in src/api/routes.ts.

Made with Cursor

…ow (JSONbored#10020) Read queue-health snapshots through listRecentSignalSnapshotsForTargets with the same trendSince window as totals, sized by QUEUE_TREND_SNAPSHOT_LIMIT.

loopover-orb · 2026-07-31T15:00:34Z

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-31 15:11:15 UTC}

5 files · 1 AI reviewer · no blockers · readiness 100/100 · CI green · clean

✅ Suggested Action - Approve/Merge

safe to merge

Review summary
This PR replaces the unbounded/latest-only `listSignalSnapshots` read for queue-health history with the same time-bounded `listRecentSignalSnapshotsForTargets(..., trendSince)` call already used for totals, and raises the per-target row clamp from 100 to 500 so a 33-day-at-4/day series isn't re-truncated. The comment at signal-snapshot.ts:126-134 correctly traces the mechanism (row_number() ranks within the in-window set per repositories.ts's existing #9699 comment), and the new regression test seeds 130 rows across 33 days and asserts the 30-day window resolves non-null duplicateTrend/stalePullRequestRateDelta — a real reproduction of the described bug, not a fabricated scenario. The `QUEUE_TREND_SNAPSHOT_LIMIT = QUEUE_TREND_HISTORY_DAYS * 4` sizing mirrors the same pattern already used in `SLOP_DUPLICATE_TREND_SNAPSHOT_LIMIT`, giving this a precedent in the codebase.

Nits — 4 non-blocking

src/db/repositories.ts:6196 — the raised clamp `500` is a bare magic number; consider a named constant (e.g. `MAX_SIGNAL_SNAPSHOT_TARGET_LIMIT`) so future callers know why 500 was chosen and don't silently reintroduce the same truncation bug with a bigger cap.
The description states 'Closes queue(signal-snapshot): time-bound the queue-health history read so the 30-day queue-trend window can resolve a baseline #10020' but the linked issue's own title only mentions the queue-health read fix; the `perTargetLimit` clamp change in repositories.ts is shared infrastructure (also used by repo-outcome-patterns.ts and maintainer-slop-duplicate-trend.ts) — worth confirming in the PR body that raising it fleet-wide to 500 doesn't unintentionally change row volume for those other unrelated callers.
Consider adding a brief note in the PR description about why 500 (not e.g. 200) was chosen as the new backstop, given SLOP_DUPLICATE_TREND_SNAPSHOT_LIMIT already caps itself at the old 100 via `Math.min` in its own comment — worth checking that comment is now stale relative to the new 500 ceiling.
src/services/queue-trends.ts — the new `QUEUE_TREND_SNAPSHOT_LIMIT` constant nicely mirrors `SLOP_DUPLICATE_TREND_SNAPSHOT_LIMIT`'s doc-comment style; keep this convention if more trend windows get similar treatment.

Decision drivers

✅ Code review — No blockers (1 reviewer)
✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#10020
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 162 registered-repo PR(s), 106 merged, 22 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	andriypolanski; Gittensor profile; 162 PR(s), 22 issue(s).
Improvement	✅ Minor	risk: clean · value: minor · LLM: moderate

Linked issue satisfaction

Addressed
The diff replaces the unbounded listSignalSnapshots call with listRecentSignalSnapshotsForTargets using the same trendSince window and a single-element target array with the documented ?? [] fallback, exports QUEUE_TREND_SNAPSHOT_LIMIT = QUEUE_TREND_HISTORY_DAYS * 4 from queue-trends.ts, leaves listSignalSnapshots' signature/limit(100) and the totals read untouched, and adds tests (including one a

Review context

Author: andriypolanski
Role context: outside_contributor
Public audience mode: oss maintainer
Lane context: Repository is configured for direct PR review.
Public profile languages: not available
Official Gittensor activity: 162 PR(s), 22 issue(s).
PR-specific overlap: none found.

Contributor next steps

Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

Related work = same linked issue, overlapping active PRs, or title/path similarity.
Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

@loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
@loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

Re-run LoopOver review

codecov · 2026-07-31T15:10:46Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.16%. Comparing base (0bc00ab) to head (2c06711).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10262      +/-   ##
==========================================
+ Coverage   80.60%   81.16%   +0.55%     
==========================================
  Files         283      286       +3     
  Lines       59101    61193    +2092     
  Branches     7000     7691     +691     
==========================================
+ Hits        47641    49667    +2026     
- Misses      11167    11178      +11     
- Partials      293      348      +55

Flag	Coverage Δ
backend	`96.84% <100.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/db/repositories.ts	`96.78% <100.00%> (ø)`
src/queue/signal-snapshot.ts	`100.00% <100.00%> (ø)`
src/services/queue-trends.ts	`96.66% <100.00%> (ø)`

loopover-orb

LoopOver approves — the gate is satisfied and CI is green.

fix(queue): time-bound queue-health history for the 30-day trend wind…

2c06711

…ow (JSONbored#10020) Read queue-health snapshots through listRecentSignalSnapshotsForTargets with the same trendSince window as totals, sized by QUEUE_TREND_SNAPSHOT_LIMIT.

andriypolanski requested a review from JSONbored as a code owner July 31, 2026 15:00

loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 31, 2026

loopover-orb Bot assigned andriypolanski Jul 31, 2026

loopover-orb Bot approved these changes Jul 31, 2026

View reviewed changes

loopover-orb Bot merged commit e5600c2 into JSONbored:main Jul 31, 2026
8 checks passed

github-actions Bot mentioned this pull request Jul 31, 2026

chore(release): cut orb-v3.7.0 #10272

Merged

Navigation Menu

Uh oh!

fix(queue): time-bound queue-health history for the 30-day trend window - #10262

fix(queue): time-bound queue-health history for the 30-day trend window#10262
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
andriypolanski:fix/10020-queue-trend-history-window

andriypolanski commented Jul 31, 2026

Uh oh!

loopover-orb Bot commented Jul 31, 2026 •

edited

Loading

✅ LoopOver review result - approve/merge recommended

Uh oh!

codecov Bot commented Jul 31, 2026

Uh oh!

loopover-orb Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

andriypolanski commented Jul 31, 2026

Summary

Scope

Validation

Safety

UI Evidence

Notes

Uh oh!

loopover-orb Bot commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ LoopOver review result - approve/merge recommended

Uh oh!

codecov Bot commented Jul 31, 2026

Codecov Report

Uh oh!

loopover-orb Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

loopover-orb Bot commented Jul 31, 2026 •

edited

Loading